Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate arrow.continuation #2672

Merged
merged 5 commits into from Feb 25, 2022
Merged

deprecate arrow.continuation #2672

merged 5 commits into from Feb 25, 2022

Conversation

i-walker
Copy link
Member

No description provided.

@i-walker i-walker marked this pull request as ready for review February 23, 2022 23:03
@i-walker i-walker requested review from nomisRev and a team February 24, 2022 08:01
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @i-walker! 🙏
Just one thought on the arrow.core.generic package for AtomicRef.

@@ -0,0 +1,52 @@
package arrow.core.generic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be under generic 🤔 Perhaps we should put it under continuation?
It's not really an arrow.core type, but it's required for the continuation runtime.

I think it's useful enough to expose since I've been using it already in some downstream MPP projects.
It's something I really miss in MPP projects and is not easily available in Kotlin since atomic-fu is not stable yet and still has some issues to be used in libraries.

Copy link
Member Author

@i-walker i-walker Feb 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, agree we can put this under arrow.generic. Maybe even create a small micro lib just with this descriptor, bc it can live without the overhead of arrow.core. What do you think? I am good with both options

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just remembered that arrow.generic is a dedicated package for generic programming in the incubator, so should we keep it under arrow.core.continuation @nomisRev ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's just keep it in arrow.core.continuation. We can always push it down into another dependency if we really need to later without making a binary breaking change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :D

@nomisRev nomisRev merged commit 1bed6da into main Feb 25, 2022
@nomisRev nomisRev deleted the deprecate-arrow-cont branch February 25, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants