Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File name generation fix #2681

Merged
merged 1 commit into from Mar 9, 2022
Merged

File name generation fix #2681

merged 1 commit into from Mar 9, 2022

Conversation

i-walker
Copy link
Member

@i-walker i-walker commented Mar 8, 2022

a mistake from #2678
files before #2678 MyGenerated.kt after org.example.MyGenerated.kt

@nomisRev
Copy link
Member

nomisRev commented Mar 9, 2022

Actually, I think in the kapt version we used org.example.MyGenerated.kt for the file names but not 100% sure.
Otherwise, you can have conflicts between two models with the same name.
For example, io.github.persistence.dto.User and io.github.model.User.

Changing the name of the file like this doesn't impact/break anything, right? @i-walker
If not I think we should leave your change, using FQN is safer than simpleName.

@nomisRev
Copy link
Member

nomisRev commented Mar 9, 2022

Discussed in person. Misunderstood the fix, and this should be merged 👍

@nomisRev nomisRev merged commit f619ad8 into main Mar 9, 2022
@nomisRev nomisRev deleted the is-ksp-file-fix branch March 9, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants