deprecate combineAll in favour of fold #2687
Conversation
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Iterable.kt
Outdated
Show resolved
Hide resolved
…erable.kt Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>
|
Agree, I‘ll take of it in this PR |
…cate-combineAll # Conflicts: # arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Iterable.kt
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Option.kt
Outdated
Show resolved
Hide resolved
| @@ -1496,7 +1496,11 @@ public fun <A, B> Either<A, B>.combine(SGA: Semigroup<A>, SGB: Semigroup<B>, b: | |||
| } | |||
| } | |||
|
|
|||
| @Deprecated("use fold instead", ReplaceWith("fold(MA, MB)", "arrow.core.fold")) | |||
There was a problem hiding this comment.
Should instead of adding this new fold method deprecate towards fold(Monoid.either(MA, MB))?
These overloads seem a bit redundant.
There was a problem hiding this comment.
I also think these overloads are redundant if we already have one instance for Either that we could take as a single argument.
I never use Monoid if I can avoid it and prefer a method that takes an empty value and an assoc function. That method already exists for Iterable, and it's just fold. In actual use cases in Kotlin, people are not going to provide their own Monoid or Semigroup instances to pass them around. These instances we provide are mainly for primitive types, but most use cases have more complex models inside the Iterable. Since users would not bother to construct complicated instances for Monoid over their model, these functions quickly become useless and need to be rewritten to basic fold or similar.
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Either.kt
Outdated
Show resolved
Hide resolved
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/map.kt
Outdated
Show resolved
Hide resolved
resolves #2682