["Request"] Improve Iterable extension impl

[raulraja]

Some of our Iterable extensions, such as partitionEither have non-optimal implementations that can be easily fixed to produce fewer allocations and iterations.

arrow/arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Iterable.kt

Line 1002 in 6aa1875

public fun <A, B> Iterable<Either<A, B>>.separateEither(): Pair<List<A>, List<B>> {

Discussion with Mitchell Cohen from slack regarding partitionEither examples: https://kotlinlang.slack.com/archives/C5UPMM0A0/p1662064718102909?thread_ts=1559561395.141900&cid=C5UPMM0A0

[Khepu]

The exact same pattern is followed here:

arrow/arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Iterable.kt

Line 1014 in 6aa1875

public fun <A, B> Iterable<Validated<A, B>>.separateValidated(): Pair<List<A>, List<B>> {

This also applies to Sequence and Option, would changes for all of those be included in the same PR?

Tests for these methods are lacking from what I could tell, would it make sense to create those?

[raulraja]

This also applies to Sequence and Option, would changes for all of those be included in the same PR?

that would be great

Tests for these methods are lacking from what I could tell, would it make sense to create those?

yes, that'd be great, thanks!

[nomisRev]

Hey @Khepu,

Tests for these methods are lacking from what I could tell, would it make sense to create those?

Yes, that would be greatly appreciated 🙏 There is some tests missing here, and there but we're trying to fill them in over time whenever we have to touch related code.

This also applies to Sequence and Option, would changes for all of those be included in the same PR?

Yes, you can include separateValidated and both methods for Sequence as well. I'm not sure this applies to Option, since Option only holds a single value, but I'm not sure which methods you're referring to.

Also feel free to put it in a separate PR if that is easier for you.