Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added docker prune command #168

Closed
wants to merge 1 commit into from

Conversation

dkr19
Copy link

@dkr19 dkr19 commented Oct 15, 2019

Fixes #154

added docker prune command

Copy link
Owner

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.
There are couple of feedbacks I have added.

  • Let's add .idea in .gitignore so it will not track intelij config files
  • Also whenever a new command is added it should have a link added in README.md and docker/README.md, you check this PR for reference kafka: create topic #162

@@ -0,0 +1,9 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file

@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file

Comment on lines +1 to +5
<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
<component name="ProjectModuleManager">
<modules>
<module fileurl="file://$PROJECT_DIR$/.idea/ak-cli.iml" filepath="$PROJECT_DIR$/.idea/ak-cli.iml" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file

@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file

@@ -0,0 +1,381 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file


`docker system prune` <br>

WARNING! This will remove:<br>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to add logs like this.
If you want to add working logs, we would love to have a gif.
Other wise just the example command is fine

Total reclaimed space: 1.84kB


#### Related Commands
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related commands should be related some where inside the repository. It should link to some other command

@arshadkazmi42
Copy link
Owner

@dkr19 Are you working on this?

@arshadkazmi42
Copy link
Owner

arshadkazmi42 commented Nov 6, 2019

Closing due to inactivity

@arshadkazmi42 arshadkazmi42 added the invalid This doesn't seem right label Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker cleanup
2 participants