Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the outer div in the datepicker #19

Open
arthurdenner opened this issue Dec 10, 2018 · 4 comments
Open

Remove the outer div in the datepicker #19

arthurdenner opened this issue Dec 10, 2018 · 4 comments
Labels

Comments

@arthurdenner
Copy link
Owner

馃寛 Feature

Right now, we have an outer div in the datepicker with the field class wrapping the Input component and the calendar. This approach has some issues, especially related to how the library behaves in forms.

We must remove this div and implement the rendering of the calendar in another way. I'm not sure how this is supposed to work, but maybe these implementations can help:

https://github.com/CompuIves/codesandbox-client/blob/master/packages/app/src/app/components/ContextMenu/index.js

https://github.com/CompuIves/codesandbox-client/blob/master/packages/app/src/app/components/Portal/index.js

@arthurdenner
Copy link
Owner Author

@lucasnsborges, you may want to take a stab at this.

@erickne
Copy link

erickne commented Jan 8, 2019

I'm probably having this issue in a form inside a modal.
image

Unfortunatelly, I to use this workaround to fix.

input {
    width: inherit !important;
}

@arthurdenner
Copy link
Owner Author

Yes, @erickne. This is probably the reason. Sorry about that. 馃槙

If you want to take a stab at this, feel free to do it, I'd appreciate a lot!

@stale
Copy link

stale bot commented Apr 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 19, 2020
@arthurdenner arthurdenner added pinned and removed stale labels Apr 19, 2020
alexrsagen added a commit to Konsept-IT/react-semantic-ui-datepickers that referenced this issue Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants