chore: Updated React component typing #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onent rather than SFC
damassi
reviewed
Jul 22, 2021
| @@ -35,7 +35,7 @@ const LargeStyle: CSSProperties = { | |||
| } | |||
|
|
|||
| // From https://www.smashingmagazine.com/2013/07/simple-responsive-images-with-css-background-images/ | |||
| const Img: React.SFC< | |||
| const Img: React.FunctionComponent< | |||
There was a problem hiding this comment.
(non-blocking) -- note you can also use the abbreviated version, React.FC
There was a problem hiding this comment.
Yeah, hesitated for a bit, but I find abbreviation confusing in code (interpretation differ from peoples), which is why I choose this way. Thanks for the feedback :D
|
🙏 |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual React functional component typings are using
SFC, which are deprecated : DefinitelyTyped/DefinitelyTyped#30364Updated them to
Functional Component