Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feature: Node 14 LTS" #199

Merged
merged 1 commit into from Sep 17, 2021
Merged

Revert "feature: Node 14 LTS" #199

merged 1 commit into from Sep 17, 2021

Conversation

mc-jones
Copy link
Contributor

@mc-jones mc-jones commented Sep 17, 2021 •
edited

Reverts the update to Node 14 LTS update, which was failing on CI.

Likely cause is an outdated version number in package.json resulting in a clash when auto bumped it up to (2.0.0) which was the existing version.

jacobherrington
jacobherrington approved these changes Sep 17, 2021
View reviewed changes
Copy link

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Reverting makes sense until we can identify the fix.

@mc-jones mc-jones merged commit 75f34e3 into master Sep 17, 2021
@mc-jones mc-jones deleted the revert-198-feature-node-14-lts branch September 17, 2021 20:24
@artsyit
Copy link
Contributor

artsyit commented Sep 17, 2021

🚀 PR was released in v2.1.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobherrington jacobherrington jacobherrington approved these changes

@icirellik icirellik Awaiting requested review from icirellik

Assignees

@jacobherrington jacobherrington

Labels
released Version: Minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mc-jones @artsyit @jacobherrington