Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more possibilities for testing #2594

Open
pvinis opened this issue Aug 7, 2020 · 2 comments
Open

Add some more possibilities for testing #2594

pvinis opened this issue Aug 7, 2020 · 2 comments

Comments

@pvinis
Copy link
Contributor

pvinis commented Aug 7, 2020

We should use the full introspection to get all fields and inputFields and be able to check what is included.

For context:
We added #2534 which is just a viewer with the root viewingRooms as viewingRoomsConnection. Then we added #2591 to have an inputField statuses. But now Viewer.viewingRoomsConnection is missing statuses so we added #2593.

In that last PR I have something I tried in the description that I will copy here.

I tried adding a test for inputFields include statuses, but I couldn't add this in an easy way.

I tried getting it by using something like getFieldsForTypeFromSchema but for inputFields, but there is no "type" that these are attached to.

I did find and try this which worked and gave me the whole schema basically. I'm sure we could use this in a test and get everything and them map it in an object that we can ask like Viewer.viewingRoomsConnection.inputFields includes statuses.

@damassi
Copy link
Member

damassi commented Aug 7, 2020

@pvinis - at some point if the path is more fleshed out it would be good to add this to platform's JIRA board with a CLIENT-INFRA label, that way we can track it better. Issues in repos tend to get lost.

@pvinis
Copy link
Contributor Author

pvinis commented Aug 7, 2020

I wasn't sure which board to throw that in. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants