Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"acceptTypes" and "type" key in records: is "types" right? #14

Open
domenic opened this issue Jan 29, 2015 · 2 comments
Open

"acceptTypes" and "type" key in records: is "types" right? #14

domenic opened this issue Jan 29, 2015 · 2 comments

Comments

@domenic
Copy link
Contributor

domenic commented Jan 29, 2015

Raised by @allenwb at the January F2F.

@domenic domenic changed the title "acceptTypes": is "types "acceptTypes": is "types" right? Jan 29, 2015
@domenic domenic changed the title "acceptTypes": is "types" right? "acceptTypes" and "type" key in records: is "types" right? Jan 29, 2015
@arv
Copy link
Owner

arv commented Jan 29, 2015

Allen's concern was that it might be confusing with types (as in number, Array etc).

types is not good because it will make things less clear if we add filtering on property names and other potential features in the future.

These kind of APIs benefit from being overly clear.

@domenic
Copy link
Contributor Author

domenic commented Jan 30, 2015

Right, I didn't mean "is 'types' the right substitute for 'acceptTypes'?" I meant "is 'types' the right word to use when describing this type of thing?"

The only alternatives I remember being mentioned in the meeting were "kind" and "action".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants