Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support notifications with Symbol-keyed properties #4

Open
ajklein opened this issue Dec 12, 2014 · 2 comments
Open

Support notifications with Symbol-keyed properties #4

ajklein opened this issue Dec 12, 2014 · 2 comments

Comments

@ajklein
Copy link
Collaborator

ajklein commented Dec 12, 2014

Current spec requires "name" to be a String.

@arv
Copy link
Owner

arv commented Dec 12, 2014

The only place [*] where this needed an update was in CreateChangeRecord which used to check if name was a string. Now it checks if name is a property key instead.

https://github.com/arv/ecmascript-object-observe/blob/master/NewInternalsSpecification.md#createchangerecordtype-object-name-olddesc-newdesc

[*] I haven't gotten to the array methods yet so leaving this open.

@rektide
Copy link

rektide commented Oct 14, 2015

Would love to see progress on this one, it's impacting my codebase. I believe, as per the original filing, symbols should be supported in a manner like strings.

Chrome bug for this: https://code.google.com/p/v8/issues/detail?id=3682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants