Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the generated converter class to the git tag #265

Closed
mojavelinux opened this issue Jun 13, 2019 · 1 comment
Closed

Publish the generated converter class to the git tag #265

mojavelinux opened this issue Jun 13, 2019 · 1 comment
Assignees
Milestone

Comments

@mojavelinux
Copy link
Member

I'm of the position that the generated converter class should be published to the git tag. In other words, all the source in the gem package should also be present somewhere in the repository. Otherwise, it looks like the gem package has code in it that isn't available (even though we know it's generated).

This would be done by committing the converter class prior to tagging the repository. It would make the tag divergent, but that's fine. What's important is that it matches the contents of the gem package (at least when it comes to the code).

@obilodeau
Copy link
Member

Sounds very reasonable. Will document and do for 3.0.0.

@obilodeau obilodeau added this to the 3.0.0 milestone Dec 31, 2019
@obilodeau obilodeau self-assigned this Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants