Javascript CLI and binary packages

[obilodeau]

Making progress but doesn't work right now.

Created the PR to get assistance from @Mogztter.

Related to #259.

[obilodeau]

I know there's a ton of crap in there. I'm trying to get it to work and then I'll cleanup.

Right now with --verbose I get:

$ npx asciidoctor-revealjs -v presentation.adoc 
require undefined
backend html5
doctype undefined
standalone true
section-numbers false
failure-level FATAL
quiet false
verbose true
timings false
trace false
base-dir undefined
destination-dir undefined
verbose-mode 2
attributes 
options {"backend":"html5","safe":"unsafe","standalone":true,"failure_level":4,"verbose":2,"timings":false,"trace":false,"mkdirs":true,"attributes":[]}
converting file presentation.adoc

backend is wrong, file is right but doesn't get converted

[obilodeau]

@Mogztter you should read #259 for struggles with pkg. I made the comments at the wrong place.

Last thing I just realized: I don't like the fact that we need both npm/asciidoctor-revealjs and packages/asciidoctor-revealjs/bin/asciidoctor-revealjs that are identical because the former is used as the CLI with npm/npx and the latter is used to build binaries (different dependencies that we don't want to force on users for the former). A solution for that would be awesome!

[ggrossetie]

Last thing I just realized: I don't like the fact that we need both npm/asciidoctor-revealjs and packages/asciidoctor-revealjs/bin/asciidoctor-revealjs that are identical because the former is used as the CLI with npm/npx and the latter is used to build binaries (different dependencies that we don't want to force on users for the former). A solution for that would be awesome!

On further consideration, I'm not sure we need to create an additional project to build the binary.
If we use a relative path to resolve the @asciidoctor/reveal.js dependency then we only need to install @asciidoctor/core.

Since we don't want to add @asciidoctor/core as a direct dependency, I guess we could install it just before we need to run pkg right?

package-bin.sh

npm i @asciidoctor/core
./node_modules/.bin/pkg -t "node12-linux-x64,node12-macos-x64,node12-win-x64" package.json --out-path dist/

[ggrossetie]

I've created a pull request: obilodeau#1 (to your branch)

[obilodeau]

Everything works! Awesome and a lot simpler. Only one remaining question.

I'm doing the docs and will update.

[obilodeau]

The plan is to squash merge this in a few hours (later tonight EST). Last chance for comments! Unless someone requests to hold on it for a little while.

[ggrossetie]

LGTM!
I left a few nitpicks but overall it's really good 👍

[ggrossetie]

👍

[obilodeau]

As a side note, we should probably update the Ruby binary bin/asciidoctor-revealjs to add the project name and version.

I got this to work (code from asciidoctor-pdf) but since I'm squash committing, I'm going to do a separate PR for this.

[ggrossetie]

Woot woot awesome work @obilodeau 🚀