Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Font Awesome to 5.15.1 #392

Merged

Conversation

ggrossetie
Copy link
Member

@ggrossetie ggrossetie commented Dec 1, 2020

Introduce an attribute to configure the version (font-awesome-version).

I also found a workaround to support brand icons.
You can declare the following:

icon:rust[2x,role=fab]

And then, add the following styles in your custom stylesheet:

/* Font Awesome 5.x Brand compatibility */
span.icon.fab > i.fa {
  font-family: "Font Awesome 5 Brands";
  font-weight: initial;
}

resolves #363

Introduce an attribute to configure the version (font-awesome-version).
@mojavelinux
Copy link
Member

icon:rust[2x,role=fab]

This is likely out of scope for this change, but I at least want to bring up the point. I think we should standardize on set like is used by Asciidoctor PDF. See https://github.com/asciidoctor/asciidoctor-pdf#font-based-icons

@ggrossetie
Copy link
Member Author

This is likely out of scope for this change, but I at least want to bring up the point

Yes, I was just experimenting 🧪
It's worth noting that I didn't introduce any change to the converter, I was showcasing a workaround that can be used today.

I think we should standardize on set like is used by Asciidoctor PDF. See asciidoctor/asciidoctor-pdf#font-based-icons

I was trying to address Olivier concern about introducing a new syntax: #304 (comment) but I also think that we should use the set attribute.
Anyway, I will create a dedicate issue and pull request to track this change.

@mojavelinux
Copy link
Member

Super!

Btw, if you want to implement the workaround, you might consider defining both role and set and eventually dropping role once support for set is implemented. Just an idea.

@ggrossetie ggrossetie merged commit 2439fe5 into asciidoctor:master Dec 3, 2020
@ggrossetie ggrossetie deleted the issue-363-font-awesome-5-15-1 branch December 3, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade font-awesome to 5.13.0
2 participants