Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested horizontal description list capturing more content than it should #3535

Closed
PHLAK opened this issue Jan 10, 2020 · 2 comments
Closed
Assignees
Labels
bug v2.0.21 Issues resolved in the 2.0.21 release
Milestone

Comments

@PHLAK
Copy link

PHLAK commented Jan 10, 2020

When creating a horizontal description list with the last term containing a nested horizontal description list it captures content even after multiple new lines.

Given this markup

[horizontal]
Term 1:: Some definition...
Term 2:: Some definition...
+
[horizontal]
Term 3::: Some definition...

A separate paragraph of text.

You get this output

image

Note how the last paragraph is being captured as part of the description list.

@mojavelinux
Copy link
Member

You're correct that it is capturing more lines than it should. However, the list continuation is redundant in this case and removing it happens to solve the issue. I'll look into how to get it to behave correctly in either case.

@mojavelinux mojavelinux added the bug label Nov 4, 2023
@mojavelinux mojavelinux self-assigned this Nov 4, 2023
@mojavelinux mojavelinux added this to the v2.0.x milestone Nov 4, 2023
mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Nov 5, 2023
…on should not consume detached paragraph
@mojavelinux
Copy link
Member

Found it. It was a regression that was not covered by a test that was caused by changing =~ to .match?

mojavelinux added a commit to mojavelinux/asciidoctor that referenced this issue Nov 6, 2023
…on should not consume detached paragraph
@mojavelinux mojavelinux added the v2.0.21 Issues resolved in the 2.0.21 release label Nov 6, 2023
mojavelinux added a commit that referenced this issue Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug v2.0.21 Issues resolved in the 2.0.21 release
Projects
None yet
Development

No branches or pull requests

2 participants