Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylesheet: Underline active footnote link #4530

Closed
Larhzu opened this issue Dec 28, 2023 · 3 comments · Fixed by #4534
Closed

Stylesheet: Underline active footnote link #4530

Larhzu opened this issue Dec 28, 2023 · 3 comments · Fixed by #4534
Assignees
Labels
design improvement v2.0.21 Issues resolved in the 2.0.21 release
Milestone

Comments

@Larhzu
Copy link
Contributor

Larhzu commented Dec 28, 2023

Test case:

= Title

Foo.footnote:[Bar]

The link after Foo is underlined in active state (keeping the mouse button pressed down) but the link before Bar isn't underlined in active state.

The following could be added for consistency with sup.footnote a:active (and #toc a:active):

#footnotes .footnote a:first-of-type:active {
  text-decoration: underline;
}

Then the section anchors would be the only links without underline in active state, which looks fine to me.

@mojavelinux
Copy link
Member

I agree there seems to be some inconsistency here. I checked and it has been like this every since I pushed the first revision of the stylesheet to the repository so I can't recall the reasoning behind it. Probably just an oversight (in an attempt to mimic the wikipedia styles).

If you would like to add the #footnotes .footnote a:first-of-type:active to the following selector, I'll merge it.

sup.footnote a:active,
sup.footnoteref a:active {
  text-decoration: underline;
}

Related to this, we are considering revamping the appearance of footnotes in a future release. See #4517.

@Larhzu
Copy link
Contributor Author

Larhzu commented Jan 2, 2024

If you would like to add the #footnotes .footnote a:first-of-type:active to the following selector, I'll merge it.

It's #4534. Hopefully it's OK.

Related to this, we are considering revamping the appearance of footnotes in a future release. See #4517.

Thanks! I don't think I have much to add, I find both C and A to be good choices.

@mojavelinux
Copy link
Member

Thanks! I'll have a look at it asap.

mojavelinux pushed a commit that referenced this issue Jan 3, 2024
update default stylesheet to underline active footnote link in footnotes list
@mojavelinux mojavelinux added the v2.0.21 Issues resolved in the 2.0.21 release label Jan 3, 2024
mojavelinux pushed a commit that referenced this issue Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design improvement v2.0.21 Issues resolved in the 2.0.21 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@mojavelinux @Larhzu and others