Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin template doesn't follow asdf "Golden Rules for Plugin Scripts" #81

Open
booniepepper opened this issue Oct 31, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@booniepepper
Copy link
Contributor

Describe the bug

The plugin template is violating the asdf project's "golden rules" for portability

Most specifically it's using echo and source liberally, and these have been considered "banned commands" for more than a year. (I understand these are bash scripts and can make assumptions but... still!)

Steps to reproduce

read the source, or generate the template

Expected behavior

No golden rule violations. In fact I'd expect the template to be enforcing this as part of linting?

Screenshots

Additional context

https://github.com/asdf-vm/asdf/blame/fce6c534daf6c0b2eed7dc633b18f7b87f665d2f/test/banned_commands.bats#L5-L24

@booniepepper booniepepper added the bug Something isn't working label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant