Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config loading doesn't actually validate / default anything #2

Open
asottile opened this issue Feb 10, 2014 · 1 comment
Open

Config loading doesn't actually validate / default anything #2

asottile opened this issue Feb 10, 2014 · 1 comment
Labels
enhancement

Comments

@asottile
Copy link
Owner

Things I'd like to do

  1. Allow for metrics and metric_expressions to be left blank and defaulted
  2. Validate that the metric names all exist in the loaded metrics (requires a db call)
asottile added a commit that referenced this issue Feb 10, 2014
@asottile
Resolves Part 1 of issue #2.
20c48c1
@asottile
Copy link
Owner Author

I'm not sure I'm comfortable solving part 2 of this issue at runtime due to needing a database access. I might instead opt for a script that validates the configuration instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asottile