Change --min-py-version behavior & always set python_requires
#179
Conversation
|
sorry it's been a while -- haven't gotten around to this. at the very least we'll need to keep the old option and have it be an alias to the new option (perhaps with a warning?) |
Perhaps we split this into multiple releases Release 1: Add a |
|
I think simpler would be to just remove the py2 code and make |
|
OK, so in cases where |
|
yep! intentionally removing any support for python 2.x packages |
|
OK. Same for tox.ini envlist & classifiers too? |
|
yep yep |
|
Dropping py2 support and enforcing that |
mxr
changed the title
--min-py3-version behavior--min-py-version behavior
mxr
force-pushed
the
parse-min
branch
2 times, most recently
from
0ba5e64
to
9bf3653
Compare
mxr
changed the title
--min-py-version behavior--min-py-version behavior & always set python_requires
| 'classifiers =\n' | ||
| ' Programming Language :: Python :: 3\n' | ||
| ' Programming Language :: Python :: 3 :: Only\n' | ||
| ' Programming Language :: Python :: 3.7\n' | ||
| ' Programming Language :: Python :: 3.8\n' | ||
| ' Programming Language :: Python :: 3.9\n' | ||
| ' Programming Language :: Python :: 3.10\n' | ||
| ' Programming Language :: Python :: 3.11\n' | ||
| ' Programming Language :: Python :: Implementation :: CPython\n' | ||
| '\n' | ||
| '[options]\n' | ||
| 'python_requires = >=3.10\n' | ||
| 'python_requires = >=3.7\n' | ||
| ) |
There was a problem hiding this comment.
I think this one is not quite right -- I think the defaulting is happening too early so it's ignoring all the tox / etc. settings?
There was a problem hiding this comment.
Ah you're right the logic I have is "specify nothing: minimum is min(3.7, python_requires minimum, tox minimum, ...)" not "[...] max(3.7, [...]"
--min-py3-versionwith--min-py-version--min-py-versionas the source of truth if supplied, otherwise infer itpython_requiresResolves #178