Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Provide a tar toolchain #470

Closed
alexeagle opened this issue Jul 11, 2023 · 1 comment
Closed

[FR]: Provide a tar toolchain #470

alexeagle opened this issue Jul 11, 2023 · 1 comment
Labels
enhancement New feature or request funding needed Contribute to https://opencollective.com/aspect-build untriaged Requires traige

Comments

@alexeagle
Copy link
Member

What is the current behavior?

rules_pkg has a bunch of issues with creating tar files that include binaries:

It would be great to have rules_pkg solve these, but many are old.
rules_oci users keep running into this because rules_docker did its own runfiles handling, which rules_oci "fixed the layering violation" by expecting the pkg_tar to create a correct output.

Describe the feature

Instead of waiting for rules_pkg, we could build an alternative. It should be simple:

  • We already have https://docs.aspect.build/rules/aspect_bazel_lib/docs/copy_to_directory/ - we can fix this to have correct handling of symlinks and runfiles. As a result, there should be a folder in bazel-out that looks exactly like what we want in the tar file.
  • Add a toolchain that provides a tar program with predictable behavior and arguments - in practice any GNU tar that's "recent enough" works. main...tar is a start.
@alexeagle alexeagle added enhancement New feature or request funding needed Contribute to https://opencollective.com/aspect-build labels Jul 11, 2023
@github-actions github-actions bot added the untriaged Requires traige label Jul 11, 2023
@alexeagle alexeagle changed the title [FR]: Provide a GNU tar toolchain [FR]: Provide a tar toolchain Oct 3, 2023
@alexeagle
Copy link
Member Author

This is landed now and will be in the 2.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request funding needed Contribute to https://opencollective.com/aspect-build untriaged Requires traige
Projects
Archived in project
Development

No branches or pull requests

1 participant