Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bzlmod #600

Merged
merged 2 commits into from Oct 8, 2023
Merged

Fix bzlmod #600

merged 2 commits into from Oct 8, 2023

Conversation

alexeagle
Copy link
Member

No description provided.

@alexeagle
fix: gazelle is not a devdep
89054df 
It's easy to see because we reference the symbol two lines below here
@alexeagle
fix: gazelle must be a regular dep
8d540ce 
I found this mistake when trying to use bazel-lib in a downstream repo.
@alexeagle alexeagle requested a review from kormide October 8, 2023 22:20
@alexeagle alexeagle merged commit 4a4dafa into 2.x Oct 8, 2023
42 checks passed
@alexeagle alexeagle deleted the fix_bzlmod branch October 8, 2023 22:57
kormide pushed a commit to kormide/bazel-lib that referenced this pull request Nov 15, 2023
@alexeagle @kormide
Fix bzlmod (aspect-build#600)
8d618ac 
* fix: gazelle is not a devdep

It's easy to see because we reference the symbol two lines below here

* fix: gazelle must be a regular dep

I found this mistake when trying to use bazel-lib in a downstream repo.
kormide pushed a commit to kormide/bazel-lib that referenced this pull request Nov 15, 2023
@alexeagle @kormide
Fix bzlmod (aspect-build#600)
5466d11 
* fix: gazelle is not a devdep

It's easy to see because we reference the symbol two lines below here

* fix: gazelle must be a regular dep

I found this mistake when trying to use bazel-lib in a downstream repo.
kormide added a commit that referenced this pull request Nov 15, 2023
@kormide @alexeagle
Fix bzlmod (#600) (#660)
d2d303a 
* fix: gazelle is not a devdep

It's easy to see because we reference the symbol two lines below here

* fix: gazelle must be a regular dep

I found this mistake when trying to use bazel-lib in a downstream repo.

Co-authored-by: Alex Eagle <alex@aspect.dev>
alexeagle added a commit that referenced this pull request Dec 23, 2023
@alexeagle
Fix bzlmod (#600)
e7487a7 
* fix: gazelle is not a devdep

It's easy to see because we reference the symbol two lines below here

* fix: gazelle must be a regular dep

I found this mistake when trying to use bazel-lib in a downstream repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kormide kormide kormide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexeagle @kormide