fix(ci): fix bzlmod issues and enable on ci #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kormide
force-pushed
the
fix-bzlmod-ci
branch
4 times, most recently
from
11c8c2d
to
70d01b7
Compare
kormide
commented
Nov 15, 2023
kormide
commented
Nov 15, 2023
kormide
force-pushed
the
fix-bzlmod-ci
branch
5 times, most recently
from
123d631
to
64ef432
Compare
kormide
changed the title
kormide
force-pushed
the
fix-bzlmod-ci
branch
2 times, most recently
from
361f73b
to
3730129
Compare
kormide
force-pushed
the
fix-bzlmod-ci
branch
from
3730129
to
8bd84fe
Compare
kormide
added a commit
to kormide/bazel-lib
that referenced
this pull request
Nov 15, 2023
kormide
added a commit
to kormide/bazel-lib
that referenced
this pull request
Nov 15, 2023
kormide
added a commit
that referenced
this pull request
Nov 15, 2023
alexeagle
pushed a commit
that referenced
this pull request
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--enable_bzlmodwas not being set on CI runs. It was attempted for windows, but was passed in the startup flags area. This exposed a bunch of bzlmod issues throughout the repo.The docs changes are just caused by a newer stardoc version.
This will need to be backported to
1.X.Type of change
Test plan