Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: support multiple targets, in line with cli api #146

Open
jackvincentnz opened this issue Apr 11, 2023 · 1 comment
Open

[FR]: support multiple targets, in line with cli api #146

jackvincentnz opened this issue Apr 11, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@jackvincentnz
Copy link

What is the current behavior?

Currently we can only pass a single target string to the rule.

Describe the feature

The cli supports passing multiple targets and will bundle based on the minimum support needed.

See the example here: https://esbuild.github.io/api/#target

I think it should be a simple fix to support passing an array of target strings rather than a single string via the rule.

@jackvincentnz jackvincentnz added the enhancement New feature or request label Apr 11, 2023
@github-actions github-actions bot added the untriaged Requires traige label Apr 11, 2023
@gregmagolan gregmagolan added this to the 1.0 milestone Apr 16, 2023
@gregmagolan gregmagolan removed the untriaged Requires traige label Apr 16, 2023
@gregmagolan
Copy link
Member

Thanks for the suggestion. If it is supported by the CLI then we shouldn't prevent it with the rule API. Added this to the 1.0 milestone for this rule set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: On Deck
Development

No branches or pull requests

2 participants