Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Support entry_points with output_dir = False #155

Open
josephglanville opened this issue Jun 17, 2023 · 2 comments
Open

[FR]: Support entry_points with output_dir = False #155

josephglanville opened this issue Jun 17, 2023 · 2 comments
Labels
enhancement New feature or request untriaged Requires traige

Comments

@josephglanville
Copy link
Contributor

What is the current behavior?

Currently when enabling either splitting or multiple entry-points then output_dir = True is enabled.

This is actually only necessary for the splitting case which will produce unpredictable output files, the multiple entry-point case will produce multiple files but those files will have predictable names based on the esbuild configuration.

Describe the feature

Setting entry_points will correctly declare outputs for each of the bundled outputs and source maps etc and only switch to output directory declaration if splitting is enabled.

@josephglanville josephglanville added the enhancement New feature or request label Jun 17, 2023
@github-actions github-actions bot added the untriaged Requires traige label Jun 17, 2023
@Place1
Copy link

Place1 commented Oct 30, 2023

I think with support for this feature we might be able to use esbuild as a transpiler in rules_ts

@josephglanville
Copy link
Contributor Author

Yeah it's essentially a requirement for use as a transpiler. I have this implemented on a branch. I will see if I can open a PR tomorrow or something after rebasing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged Requires traige
Projects
Status: No status
Development

No branches or pull requests

2 participants