Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: expose launcher_args in esbuild rule #81

Open
livemixlove opened this issue Oct 5, 2022 · 2 comments
Open

Feature request: expose launcher_args in esbuild rule #81

livemixlove opened this issue Oct 5, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@livemixlove
Copy link

Currently there's no way to pass args directly to the ESBuild executable. I'd like to use the "log-override" arg (https://esbuild.github.io/api/#log-override), but I don't think there's any way to use this currently. Am I correct?

I think the way to do this would be to allow the user to pass through args into launcher_args:
https://github.com/aspect-build/rules_esbuild/blob/main/esbuild/private/esbuild.bzl#L265

@cgrindel cgrindel added enhancement New feature or request need: discussion labels Oct 5, 2022
@cgrindel
Copy link
Contributor

@gregmagolan Any thoughts on providing a means for passing launcher args?

@alexeagle
Copy link
Member

Looking at the code it seems like https://github.com/aspect-build/rules_esbuild/blob/main/docs/esbuild.md#esbuild_bundle-args_file already gets merged into the launcher args. Seems like we just need to demo your use case in an example and document that as not only Internal Use ONly

@gregmagolan gregmagolan added this to the 1.0 milestone Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: On Deck
Development

No branches or pull requests

4 participants