[Bug]: js_image_layer is broken with bzlmod

[thesayyn]

What happened?

Currently, cross compiling js_image_layer through platform attribute is broken due to this line here where linux toolchains are not registered first like it is in the WORKSPACE version.

Version

Development (host) and target OS/architectures:

Output of bazel --version:

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file:

Language(s) and/or frameworks involved:

How to reproduce

When building the image from Darwin to Linux, the following BUILD will produce an image that contains nodejs interpreter for darwin instead of linux.


js_binary(
  name = ":binary"
)

platform(
  name = "linux_amd64",
  constraint_values = [
      "@platforms//os:linux",
      "@platforms//cpu:x86_64",
  ],
)

js_image_layer(
  name = name,
  binary = ":binary",
  platform = ":linux_amd64"
)

Any other information?

No response

[markuskobler]

Is there a simple work around for this issue other than using WORKSPACE?

[thesayyn]

You can use --extra_toolchains command line flag to register linux toolchains first. That should work.

[thesayyn]

@jbedard @gregmagolan we should make this change in rules_nodejs and include in rules_js 2.0

[gregmagolan]

@jbedard @gregmagolan we should make this change in rules_nodejs and include in rules_js 2.0

Yes, we should fix this. Possibly fix the cc toolchain coupling in the rules_nodejs provider as well.

[gregmagolan]

Duplicate of #1316

[gregmagolan]

Updated e2e/js_image_oci to build with bzlmod here #1704. That stands-in as a repro for this issue now.

[gregmagolan]

Landed on main. Fix will be included in the next rules_js 2 RC (current latest is rc4)