Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: bzlmod extension performance #1563

Open
Tracked by #1671
jbedard opened this issue Apr 1, 2024 · 0 comments
Open
Tracked by #1671

[Bug]: bzlmod extension performance #1563

jbedard opened this issue Apr 1, 2024 · 0 comments
Assignees
@jbedard
Labels
bug Something isn't working performance Improve performance of existing features
Milestone
Breaking Changes ...

Comments

@jbedard
Copy link
Member

jbedard commented Apr 1, 2024 •
edited

What happened?

The rules_js bzlmod npm extensions are slower then the repository rules today due to parsing and iterating over the lockfile+npmrc file content multiple times.

How to reproduce

Run any build using the bzlmod npm.npm_translate_lock API and a large lockfile.

Known issues/reasons:
@jbedard jbedard added the bug Something isn't working label Apr 1, 2024
@github-actions github-actions bot added the untriaged Requires traige label Apr 1, 2024
@jbedard jbedard self-assigned this Apr 1, 2024
@jbedard jbedard added performance Improve performance of existing features and removed untriaged Requires traige labels Apr 1, 2024
@alexeagle alexeagle added this to the Breaking Changes (2.0) milestone Apr 1, 2024
@gregmagolan gregmagolan mentioned this issue May 6, 2024
Open
21 tasks
@jbedard jbedard mentioned this issue May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbedard jbedard

Labels
bug Something isn't working performance Improve performance of existing features
Projects
Open Source
Status: No status
Milestone
Breaking Changes (2.0)
Development

No branches or pull requests
2 participants
@alexeagle @jbedard