You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Interesting, @jl-applied is there a use case for setting a stamp attribute on a test target? I think in theory we want to support the full py_* native rule API to make migrations easy, but this one feels more like a bug than a feature to me.
We explicitly default to stamp = false in a macro for our py_* rules. I suspect with a small refactor + slight code duplication at worse, we could workaround this without needing this attribute on any of our py_tests.
This was the first snag I hit when trying to migrate and was enough to get the migration shelved, so figured I'd open a ticket. Disallowing stamp seems reasonable to me, though an explicit comment stating this is intentional would be nice.
What happened?
Support for
py_test.stamp
, https://bazel.build/reference/be/python#py_test.stampVersion
Development (host) and target OS/architectures:
Output of
bazel --version
:bazel 5.4.0
Version of the Aspect rules, or other relevant rules from your
WORKSPACE
orMODULE.bazel
file:local rules_py workspace, HEAD
How to reproduce
https://github.com/jl-applied/rules_py/tree/jamison/161,
bazel test //examples/py:py_test
Any other information?
No response
The text was updated successfully, but these errors were encountered: