Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong dimensions when no \header present #30

Open
aspiers opened this issue Feb 4, 2013 · 4 comments
Open

wrong dimensions when no \header present #30

aspiers opened this issue Feb 4, 2013 · 4 comments
Assignees
Labels
Milestone

Comments

@aspiers
Copy link
Owner

aspiers commented Feb 4, 2013

When there is no \header present, tagline doesn't get set to ##f, which puts the dimension calculations way out.

@ghost ghost assigned aspiers Feb 4, 2013
@aspiers
Copy link
Owner Author

aspiers commented Feb 7, 2013

The workaround is obviously to add a \header.

@aspiers aspiers changed the title dies when no \header present wrong dimensions when no \header present May 20, 2023
@aspiers
Copy link
Owner Author

aspiers commented May 20, 2023

As noted by @jstma:

lilypond does not complain when there are duplicate '\header' blocks. The last one to appear will override any of those preceding. So it should be simple for ly2video to append a bit of text to the input file.

@jstma
Copy link

jstma commented May 20, 2023

As noted by @aspiers:

I figured out some of the layout issues. One is that tagline needs to be set to ##f in the \header of the LilyPond source to avoid that version footer from appearing. ly2video does this automatically, unless \header is missing (see #30). However I added 5d78897 which I thought fixed this a different way, except now I can't get it to appear even when I revert that change.

I pulled the latest changes (you've been busy!) and ran some headerless tests. No tagline was produced. If I comment out your changes in 5d78897, the tagline reappears.

It's quite confusing to test the changes because ly2video must be reinstalled each time. But I make changes and then run ly2video/cli.py directly so it's easy to do a/b tests that way.

@aspiers
Copy link
Owner Author

aspiers commented May 20, 2023

I pulled the latest changes (you've been busy!) and ran some headerless tests. No tagline was produced. If I comment out your changes in 5d78897, the tagline reappears.

That's weird, I did the same and it didn't reappear like I expected it to. Must have changed some other variable at the same time.

It's quite confusing to test the changes because ly2video must be reinstalled each time. But I make changes and then run ly2video/cli.py directly so it's easy to do a/b tests that way.

Makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants