Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format and filename extension of temporary videos should be same as output #39

Open
WebDrake opened this issue Feb 11, 2013 · 5 comments

Comments

@WebDrake
Copy link

If a title page is requested, ly2video creates 2 temporary videos and then joins them. To avoid lossy changes, the format of these videos should be the same as that of the requested output file. This should be as simple as replacing the filename extension of the interim video with that of the specified output file.

@aspiers
Copy link
Owner

aspiers commented Feb 11, 2013

Looks like you're right - the intermediate files are suffixed .mpg, but the final output file is .avi. Thanks.

@WebDrake
Copy link
Author

On 02/11/2013 07:53 PM, Adam Spiers wrote:

Looks like you're right - the intermediate files are suffixed |.mpg|, but the
final output file is |.avi|.

Well, technically the format depends on what is specified. You've always used
|.avi| in your own examples, but you could just as well use |.webm| or |.mp4|.
FFmpeg or avconv will autodetect the codecs to use based on the extension.

@aspiers
Copy link
Owner

aspiers commented Feb 11, 2013

You're right again - I momentarily forgot that .avi is the default output suffix, but can be overridden.

@WebDrake
Copy link
Author

On 02/11/2013 07:59 PM, Adam Spiers wrote:

You're right again - I momentarily forgot that |.avi| is the default output
suffix, but can be overridden.

I have a patch on the way for your consideration. :-)

@aspiers
Copy link
Owner

aspiers commented Feb 11, 2013

Excellent!

WebDrake added a commit to WebDrake/ly2video that referenced this issue Feb 11, 2013
aspiers pushed a commit that referenced this issue May 20, 2023
If a title page is requested, ly2video creates 2 temporary videos and
then joins them. To avoid lossy changes, the format of these videos
should be the same as that of the requested output file. This should
be as simple as replacing the filename extension of the interim video
with that of the specified output file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants