Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional fields to validate (?) #74

Open
laurentsimon opened this issue Feb 26, 2022 · 2 comments
Open

Additional fields to validate (?) #74

laurentsimon opened this issue Feb 26, 2022 · 2 comments

Comments

@laurentsimon
Copy link
Collaborator

laurentsimon commented Feb 26, 2022

container, run, services, environment and the workflow-call trigger could be checked for.
To be clear, none of these are valid in a job that calls a re-usable workflow. env, default, steps and runs-on are not valid either (even though I've asked checks for it) so we may as well remove them in the future. The top defaults and env don't propagate to re-usable workflows either.

The only field we really need to validate is the permissions field.

@laurentsimon
Copy link
Collaborator Author

my follow-up question is: shall we remove checks for all these fields and only keep the permission validation?

@laurentsimon
Copy link
Collaborator Author

cc @asraa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant