Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for client-specified name for Assertions class #52

Open
dancerjohn opened this issue May 16, 2018 · 1 comment
Open

Allow for client-specified name for Assertions class #52

dancerjohn opened this issue May 16, 2018 · 1 comment

Comments

@dancerjohn
Copy link

The generated entry-point class is called Assertions. If I am using the std Assertions class and my generated Assertions class in the same test, I can only import one which means the usage of the other has to be fully qualified. It would be nice to be able to add a prefix so that the generated entry-point classes are name MyProjectAssertsion, MyProjectJUnitAssertions, etc.

@dancerjohn
Copy link
Author

This would require an update AssertionsEntryPointGenerator.generateAssertionsEntryPointClassFor in assertj-assertions-generator to take an optional file name prefix. My question is, is it OK to change the method signature if I update the plugin or would an overload be better?

If this suggestion seems like a good idea, I will take a stab at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant