Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow the jakarta version of @Generated instead of the javax one. #194

Open
Zegveld opened this issue Jan 14, 2022 · 3 comments · May be fixed by #195
Open

allow the jakarta version of @Generated instead of the javax one. #194

Zegveld opened this issue Jan 14, 2022 · 3 comments · May be fixed by #195

Comments

@Zegveld
Copy link

Zegveld commented Jan 14, 2022

all javax modules are being replaced with jakarta, this includes @javax.annotation.Generated. This is replaced by @jakarta.annotation.Generated, allow users to choose which annotation they want on the generated classes.

(I'm also creating a PR for this.)
Zegveld added a commit to rigd-loxia/assertj-assertions-generator that referenced this issue Jan 14, 2022
@Zegveld
assertj#194: Make the Generated annotation configurable. You can now …
3d0a7eb 
…choose between javax.annotation.Generated and jakarta.annotation.Generated. Or if you really do not want any no annotation (not recommended).
@Zegveld Zegveld mentioned this issue Jan 14, 2022
Open
Zegveld added a commit to rigd-loxia/assertj-assertions-generator that referenced this issue Jan 26, 2022
@Zegveld
Revert "assertj#194: Make the Generated annotation configurable. You …
e592a13 
…can now choose between javax.annotation.Generated and jakarta.annotation.Generated. Or if you really do not want any no annotation (not recommended)."

This reverts commit 3d0a7eb.
Zegveld added a commit to rigd-loxia/assertj-assertions-generator that referenced this issue Jan 26, 2022
@Zegveld
assertj#194: cleaned up the autoformatting mess.
4a9b2c1
@Zegveld Zegveld linked a pull request Jan 26, 2022 that will close this issue
Open
Zegveld added a commit to rigd-loxia/assertj-assertions-generator that referenced this issue Jan 26, 2022
@Zegveld
assertj#194: Changed a test to have the jakarta annotation under test.
72bd096
@Zegveld Zegveld mentioned this issue Jan 26, 2022
Open
@famaridon
Copy link

+1

@maciejwalkowiak maciejwalkowiak mentioned this issue May 3, 2023
Closed
@rob-valor
Copy link

@joel-costigliola , any reason why the jakarta support doesn't get merged?

@joel-costigliola
Copy link
Member

just lack of time, the generator is currently in a limbo state because of that ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@joel-costigliola @famaridon @Zegveld @rob-valor