New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests failing on Windows #3183
Comments
Hi @Bananeweizen, we have windows builds as part of our CI and it works ok AFAIK. I had a look at
Same for
So maybe it's something that is dependent on your machine (admin rights or something alike) ? |
But that would mean that you are probably running your CI tests in a non standard way, with admin rights or special settings for the virtual machine. Contributors with a normal setup (and not running as administrative user all the time locally) should see the same issue as me. |
The files we manipulate should all be under a temporary directory created by JUnit, which in turn delegates to Are you sure you don't have any restrictions with your TMP folder?
We just use the GitHub-hosted Windows runners, without any special settings.
I should be able to get a similar setup. I'll have a look at it. |
Describe the bug
There are 20+ tests failing on Windows because of using unsupported features.
I have a local change that disables these test methods (for the symbolic links) or test classes (for the conversion) on Windows and with a useful message. Would that be a reasonable fix as PR? The much harder alternative would be to recognize the IOException for the missing privileges in the tests, to verify their message and that it's Windows. I'm not a fan of such tests (and the message is localized for me, so not sure whether that even works).
The text was updated successfully, but these errors were encountered: