Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try java 14 records with recursive comparison #2018

Open
joel-costigliola opened this issue Oct 13, 2020 · 5 comments · May be fixed by #3241
Open

Try java 14 records with recursive comparison #2018

joel-costigliola opened this issue Oct 13, 2020 · 5 comments · May be fixed by #3241
Labels
language: Java 17+ An issue related to using AssertJ with Java 17 or newer status: ideal for contribution An issue that a contributor can help us with theme: recursive comparison An issue related to the recursive comparison

Comments

@joel-costigliola
Copy link
Member

Summary

The recursive comparison relied on reflection to find the values to compare, let's check it that works properly with java 14 records with bare name properties enabled or disabled.
@joel-costigliola joel-costigliola mentioned this issue Oct 13, 2020
Closed
@scordio
Copy link
Member

scordio commented Sep 27, 2022

It is now possible to have dedicated tests relying on records with a new module under assertj-integration-tests.

@scordio scordio added theme: recursive comparison An issue related to the recursive comparison java: 14+ labels Sep 27, 2022
@scordio scordio added language: Java 17+ An issue related to using AssertJ with Java 17 or newer and removed java: 14+ labels Mar 2, 2023
@scordio
Copy link
Member

scordio commented Mar 2, 2023

#2968 introduced a new integration test module: assertj-core-java-17

@scordio scordio added the status: ideal for contribution An issue that a contributor can help us with label Oct 17, 2023
@etrandafir93
Copy link

etrandafir93 commented Oct 28, 2023 •
edited

hello @scordio, @joel-costigliola - I would like to get involved here.

The issue is a bit older, is it still relevant? If so, is it just a matter of adding tests for recursive comparison for records, and using both options for ExtractBareNamePropertyMethods?

@joel-costigliola
Copy link
Member Author

it is @etrandafir93, yes the idea is to play with the recursive comparison and records

@etrandafir93 etrandafir93 linked a pull request Oct 28, 2023 that will close this issue
Open
@etrandafir93
Copy link

Hello @joel-costigliola, Thanks for the quick reply.

I've added a few tests using a flat record, a nested record, and a double-nested record that contains a collection of objects. Are there other cases we should cover?

Also, I've used the static method Assertions.setExtractBareNamePropertyMethods() to test the recursive comparison with both configurations. However, since this is a static method, the tests should not run in parallel.

This is my PR link: #3241
Cheers, Emanuel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
language: Java 17+ An issue related to using AssertJ with Java 17 or newer status: ideal for contribution An issue that a contributor can help us with theme: recursive comparison An issue related to the recursive comparison
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added tests for records and recursiveComparison etrandafir93/assertj
3 participants
@joel-costigliola @scordio @etrandafir93