Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking compared fields existence: handle containers #3354

Open
4 tasks
joel-costigliola opened this issue Feb 3, 2024 · 0 comments
Open
4 tasks

Checking compared fields existence: handle containers #3354

joel-costigliola opened this issue Feb 3, 2024 · 0 comments
Assignees
@joel-costigliola
Labels
theme: recursive comparison An issue related to the recursive comparison
Milestone
3.26.0

Comments

@joel-costigliola
Copy link
Member

joel-costigliola commented Feb 3, 2024 •
edited

Summary

Checking person.children.name is not yet done (we ignore containers for the time being), in this example we need to get the first child and check if its class has a name field

We need to do the same for these containers type:

  • array
  • iterable
  • optional
  • atomic reference.

This fully fix #3349
@joel-costigliola joel-costigliola added this to the 3.26.0 milestone Feb 3, 2024
@joel-costigliola joel-costigliola added the theme: recursive comparison An issue related to the recursive comparison label Feb 3, 2024
@joel-costigliola joel-costigliola self-assigned this Feb 3, 2024
joel-costigliola pushed a commit that referenced this issue Feb 3, 2024
Ignore containers when checking compared fields existence in the recu…
ae62aca 
…rsive comparison

Fix #3349

Containers support is addressed by #3354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joel-costigliola joel-costigliola

Labels
theme: recursive comparison An issue related to the recursive comparison
Projects
None yet
Milestone
3.26.0
Development

No branches or pull requests
1 participant
@joel-costigliola