Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a better name for InstanceOfAssertFactory and InstanceOfAssertFactories #3425

Open
scordio opened this issue Apr 11, 2024 · 0 comments
Open

Find a better name for InstanceOfAssertFactory and InstanceOfAssertFactories #3425

scordio opened this issue Apr 11, 2024 · 0 comments
Labels
type: breaking change A change that modifies the behavior of an existing feature
Milestone
4.0.0

Comments

@scordio
Copy link
Member

scordio commented Apr 11, 2024

Originally introduced in #1498, InstanceOfAssertFactory and InstanceOfAssertFactories names tend to be verbose and strongly coupled with asInstanceOf.

However, InstanceOfAssertFactory is now used in many other methods like extracting(Function, InstanceOfAssertFactory).

In version 4, we might evaluate a renaming here, for example ValueType (inspired by #3368 (comment)).
@scordio scordio added type: improvement A general improvement type: breaking change A change that modifies the behavior of an existing feature labels Apr 11, 2024
@scordio scordio added this to the 4.0.0 milestone Apr 11, 2024
@scordio scordio removed the type: improvement A general improvement label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: breaking change A change that modifies the behavior of an existing feature
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
1 participant
@scordio