Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Java 17 #3442

Open
scordio opened this issue Apr 24, 2024 · 1 comment · May be fixed by #3447
Open

Move to Java 17 #3442

scordio opened this issue Apr 24, 2024 · 1 comment · May be fixed by #3447
Labels
Hackergarten An issue reserved for Hackergarten events (https://www.hackergarten.net/)
Milestone

Comments

@scordio
Copy link
Member

scordio commented Apr 24, 2024

We want AssertJ 4 to use and require Java 17.

This mostly means increasing the java.version Maven property to 17.

In addition, we can:

  • Move the tests from assertj-core-java-17 to assertj-core and delete assertj-core-java-17
  • Replace any usage of List.of, Set.of, and Map.of from Jdk11 with the corresponding JDK API and delete the org.assertj.core.test.jdk11 package
@scordio scordio added the Hackergarten An issue reserved for Hackergarten events (https://www.hackergarten.net/) label Apr 24, 2024
@scordio scordio added this to the 4.0.0 milestone Apr 24, 2024
@scordio
Copy link
Member Author

scordio commented Apr 25, 2024

Move the tests from assertj-core-java-17 to assertj-core and delete assertj-core-java-17

We should rather go in the opposite direction due to using the module path only.

We'll take care of this in #3446.

@scordio scordio linked a pull request Apr 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hackergarten An issue reserved for Hackergarten events (https://www.hackergarten.net/)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant