Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in jsdom@^23.0.0 for tough-cookie@4.1.3 #1297

Open
JoshuaKGoldberg opened this issue Dec 28, 2023 · 2 comments
Open

Pull in jsdom@^23.0.0 for tough-cookie@4.1.3 #1297

JoshuaKGoldberg opened this issue Dec 28, 2023 · 2 comments

Comments

@JoshuaKGoldberg
Copy link

馃憢 Hi! Coming over from mochajs/mocha#5070, there's a trail in our dependencies that ends with an old version of tough-cookie and starts with our dependency on assetgraph. Bottom-to-top:

Would you accept a PR that bumps jsdom to ^23.0.0?

AssetGraph is very cool by the way. Thanks for working on it! 馃槃

@JoshuaKGoldberg JoshuaKGoldberg changed the title Pull in jsdom@^4.1.3 for tough-cookie@ Pull in jsdom@^4.1.3 for tough-cookie@4.1.3 Dec 28, 2023
@JoshuaKGoldberg JoshuaKGoldberg changed the title Pull in jsdom@^4.1.3 for tough-cookie@4.1.3 Pull in jsdom@^23.0.0 for tough-cookie@4.1.3 Dec 28, 2023
@papandreou
Copy link
Member

Sure, but note that we do releases from the v7 branch, where jsdom is at 16.x and we still support node.js 12. Jsdom tends to be quite aggressive with not supporting older node versions, so we can't really upgrade to ^23 until we release a new major of assetgraph.

@papandreou
Copy link
Member

AssetGraph doesn't make use of jsdom's ability to load related assets via HTTP, so the npm audit error is purely cosmetic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants