Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] abstract scan/run command as mpsc based Worker #138

Closed
HerringtonDarkholme opened this issue Dec 19, 2022 · 0 comments
Closed

[refactor] abstract scan/run command as mpsc based Worker #138

HerringtonDarkholme opened this issue Dec 19, 2022 · 0 comments
Assignees
@HerringtonDarkholme
Labels
refactor Better engineering refactor

Comments

@HerringtonDarkholme
Copy link
Member

This can help organize a lot of common code in scan/run command.

trait Worker {
  type Item;
  fn walker() -> Walker;
  fn producer() -> Item;
  fn consumer(i: Item) -> Result<()>;
}
@HerringtonDarkholme HerringtonDarkholme added the refactor Better engineering refactor label Dec 19, 2022
@HerringtonDarkholme HerringtonDarkholme self-assigned this Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HerringtonDarkholme HerringtonDarkholme

Labels
refactor Better engineering refactor
Projects
ast-grep's roadmap
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HerringtonDarkholme