From 1ebf1c384e1bbec44b4b5350a8bf7af86cb0dd3d Mon Sep 17 00:00:00 2001 From: Micha Reiser Date: Thu, 19 Oct 2023 10:14:12 +0900 Subject: [PATCH] remove line-width option from LinterSettings --- crates/ruff_cli/src/args.rs | 2 +- crates/ruff_cli/tests/lint.rs | 10 +++--- .../rules/flake8_simplify/rules/ast_with.rs | 2 +- .../flake8_simplify/rules/collapsible_if.rs | 2 +- .../if_else_block_instead_of_dict_get.rs | 2 +- .../rules/if_else_block_instead_of_if_exp.rs | 2 +- .../rules/reimplemented_builtin.rs | 4 +-- .../src/rules/isort/rules/organize_imports.rs | 2 +- .../ruff_linter/src/rules/pycodestyle/mod.rs | 2 +- .../rules/pycodestyle/rules/line_too_long.rs | 3 +- .../src/rules/pyupgrade/rules/f_strings.rs | 2 +- crates/ruff_linter/src/settings/mod.rs | 4 +-- crates/ruff_workspace/src/configuration.rs | 14 +++++--- crates/ruff_workspace/src/options.rs | 33 ++++++++++--------- ruff.schema.json | 8 ++--- 15 files changed, 49 insertions(+), 43 deletions(-) diff --git a/crates/ruff_cli/src/args.rs b/crates/ruff_cli/src/args.rs index b140dd71b0b3fc..e5bfe977965c0f 100644 --- a/crates/ruff_cli/src/args.rs +++ b/crates/ruff_cli/src/args.rs @@ -689,7 +689,7 @@ impl ConfigurationTransformer for CliOverrides { if let Some(line_length) = self.line_length { config.line_length = Some(line_length); config.lint.pycodestyle = Some(PycodestyleOptions { - max_line_width: Some(line_length), + max_line_length: Some(line_length), ..config.lint.pycodestyle.unwrap_or_default() }); } diff --git a/crates/ruff_cli/tests/lint.rs b/crates/ruff_cli/tests/lint.rs index 86f5892bd9bd93..f6a7a2a99f60f2 100644 --- a/crates/ruff_cli/tests/lint.rs +++ b/crates/ruff_cli/tests/lint.rs @@ -278,11 +278,11 @@ fn line_too_long_width_override() -> Result<()> { fs::write( &ruff_toml, r#" -line-width = 80 +line-length = 80 select = ["E501"] [pycodestyle] -max-line-width = 100 +max-line-length = 100 "#, )?; @@ -293,15 +293,15 @@ max-line-width = 100 .args(["--stdin-filename", "test.py"]) .arg("-") .pass_stdin(r#" -# wider than 80, but less than 100 +# longer than 80, but less than 100 _ = "---------------------------------------------------------------------------亜亜亜亜亜亜" -# wider than 100 +# longer than 100 _ = "---------------------------------------------------------------------------亜亜亜亜亜亜亜亜亜亜亜亜亜亜" "#), @r###" success: false exit_code: 1 ----- stdout ----- - test.py:5:91: E501 Line too long (109 > 100 width) + test.py:5:91: E501 Line too long (109 > 100) Found 1 error. ----- stderr ----- diff --git a/crates/ruff_linter/src/rules/flake8_simplify/rules/ast_with.rs b/crates/ruff_linter/src/rules/flake8_simplify/rules/ast_with.rs index 7294ccfb8741bd..e3dedd26a477c9 100644 --- a/crates/ruff_linter/src/rules/flake8_simplify/rules/ast_with.rs +++ b/crates/ruff_linter/src/rules/flake8_simplify/rules/ast_with.rs @@ -139,7 +139,7 @@ pub(crate) fn multiple_with_statements( content, with_stmt.into(), checker.locator(), - checker.settings.line_length, + checker.settings.pycodestyle.max_line_length, checker.settings.tab_size, ) }) { diff --git a/crates/ruff_linter/src/rules/flake8_simplify/rules/collapsible_if.rs b/crates/ruff_linter/src/rules/flake8_simplify/rules/collapsible_if.rs index b8c825404e788c..584c8c4182a2ca 100644 --- a/crates/ruff_linter/src/rules/flake8_simplify/rules/collapsible_if.rs +++ b/crates/ruff_linter/src/rules/flake8_simplify/rules/collapsible_if.rs @@ -128,7 +128,7 @@ pub(crate) fn nested_if_statements( content, (&nested_if).into(), checker.locator(), - checker.settings.line_length, + checker.settings.pycodestyle.max_line_length, checker.settings.tab_size, ) }) { diff --git a/crates/ruff_linter/src/rules/flake8_simplify/rules/if_else_block_instead_of_dict_get.rs b/crates/ruff_linter/src/rules/flake8_simplify/rules/if_else_block_instead_of_dict_get.rs index 392156acab946d..50d6e8b7bb1297 100644 --- a/crates/ruff_linter/src/rules/flake8_simplify/rules/if_else_block_instead_of_dict_get.rs +++ b/crates/ruff_linter/src/rules/flake8_simplify/rules/if_else_block_instead_of_dict_get.rs @@ -195,7 +195,7 @@ pub(crate) fn if_else_block_instead_of_dict_get(checker: &mut Checker, stmt_if: &contents, stmt_if.into(), checker.locator(), - checker.settings.line_length, + checker.settings.pycodestyle.max_line_length, checker.settings.tab_size, ) { return; diff --git a/crates/ruff_linter/src/rules/flake8_simplify/rules/if_else_block_instead_of_if_exp.rs b/crates/ruff_linter/src/rules/flake8_simplify/rules/if_else_block_instead_of_if_exp.rs index e7eeccb661b207..c44c3d2a1c13cb 100644 --- a/crates/ruff_linter/src/rules/flake8_simplify/rules/if_else_block_instead_of_if_exp.rs +++ b/crates/ruff_linter/src/rules/flake8_simplify/rules/if_else_block_instead_of_if_exp.rs @@ -130,7 +130,7 @@ pub(crate) fn if_else_block_instead_of_if_exp(checker: &mut Checker, stmt_if: &a &contents, stmt_if.into(), checker.locator(), - checker.settings.line_length, + checker.settings.pycodestyle.max_line_length, checker.settings.tab_size, ) { return; diff --git a/crates/ruff_linter/src/rules/flake8_simplify/rules/reimplemented_builtin.rs b/crates/ruff_linter/src/rules/flake8_simplify/rules/reimplemented_builtin.rs index 651b775ddf338a..53e911e2977795 100644 --- a/crates/ruff_linter/src/rules/flake8_simplify/rules/reimplemented_builtin.rs +++ b/crates/ruff_linter/src/rules/flake8_simplify/rules/reimplemented_builtin.rs @@ -101,7 +101,7 @@ pub(crate) fn convert_for_loop_to_any_all(checker: &mut Checker, stmt: &Stmt) { &contents, stmt.into(), checker.locator(), - checker.settings.line_length, + checker.settings.pycodestyle.max_line_length, checker.settings.tab_size, ) { return; @@ -188,7 +188,7 @@ pub(crate) fn convert_for_loop_to_any_all(checker: &mut Checker, stmt: &Stmt) { .slice(TextRange::new(line_start, stmt.start())), ) .add_str(&contents) - > checker.settings.line_length + > checker.settings.pycodestyle.max_line_length { return; } diff --git a/crates/ruff_linter/src/rules/isort/rules/organize_imports.rs b/crates/ruff_linter/src/rules/isort/rules/organize_imports.rs index e571271d08c003..4b0e6c7afc8f45 100644 --- a/crates/ruff_linter/src/rules/isort/rules/organize_imports.rs +++ b/crates/ruff_linter/src/rules/isort/rules/organize_imports.rs @@ -120,7 +120,7 @@ pub(crate) fn organize_imports( block, comments, locator, - settings.line_length, + settings.pycodestyle.max_line_length, LineWidthBuilder::new(settings.tab_size).add_str(indentation), stylist, &settings.src, diff --git a/crates/ruff_linter/src/rules/pycodestyle/mod.rs b/crates/ruff_linter/src/rules/pycodestyle/mod.rs index c48d29da30f406..d91a46ff81fcb5 100644 --- a/crates/ruff_linter/src/rules/pycodestyle/mod.rs +++ b/crates/ruff_linter/src/rules/pycodestyle/mod.rs @@ -231,7 +231,7 @@ mod tests { &settings::LinterSettings { tab_size: NonZeroU8::new(tab_size).unwrap().into(), pycodestyle: pycodestyle::settings::Settings { - max_line_width: LineLength::try_from(6).unwrap(), + max_line_length: LineLength::try_from(6).unwrap(), ..pycodestyle::settings::Settings::default() }, ..settings::LinterSettings::for_rule(Rule::LineTooLong) diff --git a/crates/ruff_linter/src/rules/pycodestyle/rules/line_too_long.rs b/crates/ruff_linter/src/rules/pycodestyle/rules/line_too_long.rs index c5f0e2ddd73b87..d803cfa5591496 100644 --- a/crates/ruff_linter/src/rules/pycodestyle/rules/line_too_long.rs +++ b/crates/ruff_linter/src/rules/pycodestyle/rules/line_too_long.rs @@ -47,6 +47,7 @@ use crate::settings::LinterSettings; /// /// ## Options /// - `line-length` +/// - `pycodestyle.max-line-length` /// - `task-tags` /// - `pycodestyle.ignore-overlong-task-comments` /// @@ -68,7 +69,7 @@ pub(crate) fn line_too_long( indexer: &Indexer, settings: &LinterSettings, ) -> Option { - let limit = settings.pycodestyle.max_line_width; + let limit = settings.pycodestyle.max_line_length; Overlong::try_from_line( line, diff --git a/crates/ruff_linter/src/rules/pyupgrade/rules/f_strings.rs b/crates/ruff_linter/src/rules/pyupgrade/rules/f_strings.rs index 290a7cd55294ae..5fc0ba15a6e8c5 100644 --- a/crates/ruff_linter/src/rules/pyupgrade/rules/f_strings.rs +++ b/crates/ruff_linter/src/rules/pyupgrade/rules/f_strings.rs @@ -399,7 +399,7 @@ pub(crate) fn f_strings( &contents, template.into(), checker.locator(), - checker.settings.line_length, + checker.settings.pycodestyle.max_line_length, checker.settings.tab_size, ) { return; diff --git a/crates/ruff_linter/src/settings/mod.rs b/crates/ruff_linter/src/settings/mod.rs index 699288a4e07677..c72dc70b00b834 100644 --- a/crates/ruff_linter/src/settings/mod.rs +++ b/crates/ruff_linter/src/settings/mod.rs @@ -26,7 +26,7 @@ use crate::rules::{ use crate::settings::types::{FilePatternSet, PerFileIgnore, PythonVersion}; use crate::{codes, RuleSelector}; -use super::line_width::{LineLength, TabSize}; +use super::line_width::TabSize; use self::rule_table::RuleTable; use self::types::PreviewMode; @@ -56,7 +56,6 @@ pub struct LinterSettings { pub dummy_variable_rgx: Regex, pub external: FxHashSet, pub ignore_init_module_imports: bool, - pub line_length: LineLength, pub logger_objects: Vec, pub namespace_packages: Vec, pub src: Vec, @@ -147,7 +146,6 @@ impl LinterSettings { external: HashSet::default(), ignore_init_module_imports: false, - line_length: LineLength::default(), logger_objects: vec![], namespace_packages: vec![], diff --git a/crates/ruff_workspace/src/configuration.rs b/crates/ruff_workspace/src/configuration.rs index 5e4f98c9114715..f8d554746259f4 100644 --- a/crates/ruff_workspace/src/configuration.rs +++ b/crates/ruff_workspace/src/configuration.rs @@ -21,6 +21,7 @@ use ruff_linter::line_width::{LineLength, TabSize}; use ruff_linter::registry::RuleNamespace; use ruff_linter::registry::{Rule, RuleSet, INCOMPATIBLE_CODES}; use ruff_linter::rule_selector::{PreviewOptions, Specificity}; +use ruff_linter::rules::pycodestyle; use ruff_linter::settings::rule_table::RuleTable; use ruff_linter::settings::types::{ FilePattern, FilePatternSet, PerFileIgnore, PreviewMode, PythonVersion, SerializationFormat, @@ -227,7 +228,6 @@ impl Configuration { .unwrap_or_else(|| DUMMY_VARIABLE_RGX.clone()), external: FxHashSet::from_iter(lint.external.unwrap_or_default()), ignore_init_module_imports: lint.ignore_init_module_imports.unwrap_or_default(), - line_length, tab_size: self.tab_size.unwrap_or_default(), namespace_packages: self.namespace_packages.unwrap_or_default(), per_file_ignores: resolve_per_file_ignores( @@ -348,10 +348,14 @@ impl Configuration { .map(Pep8NamingOptions::try_into_settings) .transpose()? .unwrap_or_default(), - pycodestyle: lint - .pycodestyle - .map(|options| options.into_settings(line_length)) - .unwrap_or_default(), + pycodestyle: if let Some(pycodestyle) = lint.pycodestyle { + pycodestyle.into_settings(line_length) + } else { + pycodestyle::settings::Settings { + max_line_length: line_length, + ..pycodestyle::settings::Settings::default() + } + }, pydocstyle: lint .pydocstyle .map(PydocstyleOptions::into_settings) diff --git a/crates/ruff_workspace/src/options.rs b/crates/ruff_workspace/src/options.rs index 351ffca8798ad3..90e5691c5742c1 100644 --- a/crates/ruff_workspace/src/options.rs +++ b/crates/ruff_workspace/src/options.rs @@ -60,7 +60,7 @@ pub struct Options { /// this base configuration file, then merge in any properties defined /// in the current configuration file. #[option( - default = r#"None"#, + default = r#"null"#, value_type = "str", example = r#" # Extend the `pyproject.toml` file in the parent directory. @@ -132,7 +132,7 @@ pub struct Options { /// results across many environments, e.g., with a `pyproject.toml` /// file). #[option( - default = "None", + default = "null", value_type = "str", example = r#" required-version = "0.0.193" @@ -362,6 +362,8 @@ pub struct Options { /// Note: The `line-length` isn't a hard upper limit for the formatter. /// It is a way to tell the formatter roughly how long you'd like your lines to be. /// The formatter will both make shorter and longer lines, but generally strives to not exceed the specified length. + /// + /// See [`pycodestyle.max-line-length`](#pycodestyle-max-line-length) to configure different lengths for `E501` and the formatter. #[option( default = "88", value_type = "int", @@ -1043,7 +1045,7 @@ pub struct Flake8CopyrightOptions { /// Author to enforce within the copyright notice. If provided, the /// author must be present immediately following the copyright notice. - #[option(default = "None", value_type = "str", example = r#"author = "Ruff""#)] + #[option(default = "null", value_type = "str", example = r#"author = "Ruff""#)] pub author: Option, /// A minimum file size (in bytes) required for a copyright notice to @@ -2247,30 +2249,31 @@ impl Pep8NamingOptions { #[serde(deny_unknown_fields, rename_all = "kebab-case")] #[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))] pub struct PycodestyleOptions { - /// The maximum [width](http://www.unicode.org/reports/tr11/#Overview) to allow for [`line-too-long`] violations. By default, - /// this is set to the value of the global `line-width` option. + /// The maximum line length to allow for [`line-too-long`](https://docs.astral.sh/ruff/rules/line-too-long/) violations. By default, + /// this is set to the value of the [`line-length`](#line-length) option. /// - /// Overriding the global [`line-width`] allows to use a lower limit for Ruff's formatter and warn about - /// extra-long lines that can't be split by the formatter using [`line-too-long`]: + /// Use this option when you want to detect extra-long lines that the formatter can't automatically split by setting + /// `pycodestyle.line-length` to a value larger than [`line-length`](#line-length). /// /// ```toml - /// line-width = 88 # The formatter breaks line's with a width of 88. + /// line-length = 88 # The formatter wraps lines at a length of 88 /// /// [pycodestyle] - /// max-line-width = 100 # E501 reports lines that exceed the width of 100. + /// max-line-length = 100 # E501 reports lines that exceed the length of 100. /// ``` /// - /// [`line-too-long`]. + /// The length is determined by the number of characters per line, except for lines containing East Asian characters or emojis. + /// For these lines, the [unicode width](https://unicode.org/reports/tr11/) of each character is added up to determine the length. /// /// See the [`line-too-long`](https://docs.astral.sh/ruff/rules/line-too-long/) rule for more information. #[option( default = "null", value_type = "int", example = r#" - max-line-width = 100 + max-line-length = 100 "# )] - pub max_line_width: Option, + pub max_line_length: Option, /// The maximum line length to allow for [`doc-line-too-long`](https://docs.astral.sh/ruff/rules/doc-line-too-long/) violations within /// documentation (`W505`), including standalone comments. By default, @@ -2281,7 +2284,7 @@ pub struct PycodestyleOptions { /// /// See the [`doc-line-too-long`](https://docs.astral.sh/ruff/rules/doc-line-too-long/) rule for more information. #[option( - default = "None", + default = "null", value_type = "int", example = r#" max-doc-length = 88 @@ -2306,7 +2309,7 @@ impl PycodestyleOptions { pub fn into_settings(self, global_line_length: LineLength) -> pycodestyle::settings::Settings { pycodestyle::settings::Settings { max_doc_length: self.max_doc_length, - max_line_width: self.max_line_length.unwrap_or(global_line_length), + max_line_length: self.max_line_length.unwrap_or(global_line_length), ignore_overlong_task_comments: self.ignore_overlong_task_comments.unwrap_or_default(), } } @@ -2347,7 +2350,7 @@ pub struct PydocstyleOptions { /// enabling _additional_ rules on top of a convention is currently /// unsupported. #[option( - default = r#"None"#, + default = r#"null"#, value_type = r#""google" | "numpy" | "pep257""#, example = r#" # Use Google-style docstrings. diff --git a/ruff.schema.json b/ruff.schema.json index 5c24b2d6455ab1..72c3735736cce5 100644 --- a/ruff.schema.json +++ b/ruff.schema.json @@ -425,7 +425,7 @@ ] }, "line-length": { - "description": "The line length to use when enforcing long-lines violations (like `E501`) and at which the formatter prefers to wrap lines.\n\nThe length is determined by the number of characters per line, except for lines containing East Asian characters or emojis. For these lines, the [unicode width](https://unicode.org/reports/tr11/) of each character is added up to determine the length.\n\nThe value must be greater than `0` and less than or equal to `320`.\n\nNote: The `line-length` isn't a hard upper limit for the formatter. It is a way to tell the formatter roughly how long you'd like your lines to be. The formatter will both make shorter and longer lines, but generally strives to not exceed the specified length.", + "description": "The line length to use when enforcing long-lines violations (like `E501`) and at which the formatter prefers to wrap lines.\n\nThe length is determined by the number of characters per line, except for lines containing East Asian characters or emojis. For these lines, the [unicode width](https://unicode.org/reports/tr11/) of each character is added up to determine the length.\n\nThe value must be greater than `0` and less than or equal to `320`.\n\nNote: The `line-length` isn't a hard upper limit for the formatter. It is a way to tell the formatter roughly how long you'd like your lines to be. The formatter will both make shorter and longer lines, but generally strives to not exceed the specified length.\n\nSee [`pycodestyle.max-line-length`](#pycodestyle-max-line-length) to configure different lengths for `E501` and the formatter.", "anyOf": [ { "$ref": "#/definitions/LineLength" @@ -2205,11 +2205,11 @@ } ] }, - "max-line-width": { - "description": "The maximum [width](http://www.unicode.org/reports/tr11/#Overview) to allow for [`line-too-long`] violations. By default, this is set to the value of the global `line-width` option.\n\nOverriding the global [`line-width`] allows to use a lower limit for Ruff's formatter and warn about extra-long lines that can't be split by the formatter using [`line-too-long`]:\n\n```toml line-width = 88 # The formatter breaks line's with a width of 88.\n\n[pycodestyle] max-line-width = 100 # E501 reports lines that exceed the width of 100. ```\n\n[`line-too-long`].\n\nSee the [`line-too-long`](https://docs.astral.sh/ruff/rules/line-too-long/) rule for more information.", + "max-line-length": { + "description": "The maximum line length to allow for [`line-too-long`](https://docs.astral.sh/ruff/rules/line-too-long/) violations. By default, this is set to the value of the [`line-length`](#line-length) option.\n\nUse this option when you want to detect extra-long lines that the formatter can't automatically split by setting `pycodestyle.line-length` to a value larger than [`line-length`](#line-length).\n\n```toml line-length = 88 # The formatter wraps lines at a length of 88\n\n[pycodestyle] max-line-length = 100 # E501 reports lines that exceed the length of 100. ```\n\nThe length is determined by the number of characters per line, except for lines containing East Asian characters or emojis. For these lines, the [unicode width](https://unicode.org/reports/tr11/) of each character is added up to determine the length.\n\nSee the [`line-too-long`](https://docs.astral.sh/ruff/rules/line-too-long/) rule for more information.", "anyOf": [ { - "$ref": "#/definitions/LineWidth" + "$ref": "#/definitions/LineLength" }, { "type": "null"