Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 7 commits
- 34 files changed
- 4 contributors
Commits on Jan 12, 2024
-
Include base pyproject when initializing cache settings (#9480)
## Summary Regression from https://github.com/astral-sh/ruff/pull/9453/files#diff-80a9c2637c432502a7075c792cc60db92282dd786999a78bfa9bb6f025afab35L482. Closes #9478. ## Test Plan ``` rm -rf .ruff_cache cargo run -p ruff_cli -- check ../foo.py ``` Failed prior to this PR; passes afterwards. The file must be outside of the current working directory, and must not have a `pyproject.toml` in any parent directory.
-
Remove
unreachable-codefeature (#9463)## Summary We haven't found time to flip this on, so feels like it's best to remove it for now -- can always restore from source when we get back to it.
-
(🐞) Add the missing period in error message (#9485)
<!-- Thank you for contributing to Ruff! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary <!-- What's the purpose of the change? What does it do, and why? --> I noticed that there should be a missing period added to some of the new error messages for Unnecessary dunder call: ``` sandpit\test.py:6:16: PLC2801 Unnecessary dunder call to `__getattribute__`. Access attribute directly or use getattr built-in function.. ``` ## Test Plan Static analysis of the implementation, as this has no existing test cases.
-
Fix backticks in RUF021 docs (#9488)
The docs for this rule aren't generating properly: https://docs.astral.sh/ruff/rules/parenthesize-chained-operators/#why-is-this-bad. I assume this is the reason why!
-
Fix message for __aenter__ in PLC2801 (#9492)
<!-- Thank you for contributing to Ruff! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary Fix the message for `__aenter__ ` in PLC2801 (introduced in #9166) There is no `aenter` builtin in Python, so the current message is misleading. I take the message from original lint https://github.com/pylint-dev/pylint/blob/main/pylint/constants.py#L211 P.S. I think here should be more accurate synchronization with original lint (e.g. the current implementation will not lint `__enter__` on my first sight), but it is out-of-scope of this change. <!-- What's the purpose of the change? What does it do, and why? --> ## Test Plan <!-- How was it tested? -->
-
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.1.12...v0.1.13