False positive for F821 on circular reference in TYPE_CHECKING block

[ngnpope]

Keywords searched for before creating issue: F821, TYPE_CHECKING.

Example code that produces the false positive:

from __future__ import annotations

from typing import TYPE_CHECKING, TypeAlias

if TYPE_CHECKING:
    Nested: TypeAlias = dict[str, bool | Nested]

Command line and output:

$ ruff --version
ruff 0.4.2
$ ruff check --isolated --select=F821 bug.py 
bug.py:6:42: F821 Undefined name `Nested`
Found 1 error.
$ mypy --strict bug.py 
Success: no issues found in 1 source file

Expected that F821 would not be raised in a TYPE_CHECKING block for a circular reference when using postponed evaluation of annotations (PEP 563).

[trag1c]

nit: indeed, PEP 563 applies to annotations, but dict[str, bool | Nested] isn't one (in fact the __future__ import doesn't make a difference).

I think the issue is still valid though 👍

[charliermarsh]

Not sure... @AlexWaygood would know.

[AlexWaygood]

Yeah I think from __future__ import annotations is irrelevant here, but if it's in an if TYPE_CHECKING block we should treat it as though it has "stub file" semantics (whether or not __future__ annotations are enabled). The rhs of an assignment is evaluated at runtime regardless of whether __future__ annotations are enabled, but nothing in an if TYPE_CHECKING block is ever evaluated at runtime, so it doesn't matter

TL;DR: I agree that this is a false positive

[AlexWaygood]

If you tried to use Nested in a type annotation anywhere without either quoting it or having __future__ annotations enabled, it would fail, because the alias doesn't exist at runtime. But that's a separate issue