Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot apply scoped style to the form from parent #301

Open
3 tasks
ayoayco opened this issue May 16, 2023 · 0 comments
Open
3 tasks

fix: cannot apply scoped style to the form from parent #301

ayoayco opened this issue May 16, 2023 · 0 comments

Comments

@ayoayco
Copy link
Member

ayoayco commented May 16, 2023

This fix is gonna take some refactors and will be a breaking change for the good.

Astro defaults the <style> to a scoped behavior by only applying the style rules to component elements which received a unique class.

This unique class is not applied to children components by default but we can:

  • Accept a class prop
  • spread this class name to all child elements inside Form

Also: right now each field is in a div which makes it a bit opinionated.

  • Let's follow a more flexible, recommended, semantic HTML for the form on this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant