Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature Request: Handling retry at the notebook level #65

Open
RafaelCartenet opened this issue Mar 12, 2024 · 3 comments
Open

New Feature Request: Handling retry at the notebook level #65

RafaelCartenet opened this issue Mar 12, 2024 · 3 comments

Comments

@RafaelCartenet
Copy link

Hey, been using the library for a while now, love it, thanks for the good work.
Trying to implement retry at the notebook level, Databricks have parameters for it you can change in the UI that appear like this in the json:

{
  "task_key": "databricks_lol__champion_builds__champion_builds_gold_0",
  ...
  "max_retries": 2,
  "min_retry_interval_millis": 60000,
  "retry_on_timeout": true,
  "timeout_seconds": 1200,
}

I'm unable to set those parameters with astro_databricks

Thanks in advance

@tatiana
Copy link
Collaborator

tatiana commented May 9, 2024

Hi, @RafaelCartenet, this is a handy feature.
We could also have this associated with the Airflow task retry, so Airflow could automatically retry tasks on failure.
Would you be interested in contributing to the project?

@RafaelCartenet
Copy link
Author

RafaelCartenet commented May 13, 2024 via email

@tatiana
Copy link
Collaborator

tatiana commented May 14, 2024

Hi @RafaelCartenet !

Those are great questions. Astronomer is contributing this provider to the Apache Airflow Databricks provider so it can be part of a larger community - both users and contributors.

These are the steps:

  1. Contribute DatabricksNotebookOperator to Airflow Databricks provider ✅ (Add DatabricksNotebookOperator apache/airflow#39178)
  2. Contribute DatabricksWorkflowTaskGroup to Airflow Databricks provider 🚧
  3. Contribute DatabricksTaskOperator to Airflow Databricks provider
  4. Contribute the Astro Provider Databricks plugin to Airflow Databricks provider
  5. Add deferrable support for donated Databricks operators 🚧 (add deferrable support to DatabricksNotebookOperator apache/airflow#39295)
  6. Mark deprecation for astro-provider-databricks repo

I see the feature you requested being developed / contributed after the migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants