Update axum integration version #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently axum `0.6.*` is not fully released, this commit will need to be updated to target the full release version.
|
We should probably wait until axum 0.6.* is fully released before we merge this. |
|
Thanks, it will be merged when |
In axum 0.6.* `FromRequest` always consumes the request's body. `FromRequestParts` was also introduced for when you don't need to consume the body. You can read about it more in axum's changelog.
We need some way to document how to use this crate for users who are yet to upgrade to axum `0.6.*`. The idea here is that when we publish the crate again we will increase it's version making `4.0.15` the last version supporting axum `0.5.*`.
tomerze
force-pushed
the
upgrade-axum-integ-version
branch
from
7a5acd8
to
1e7cd4e
Compare
sunli829
force-pushed
the
master
branch
3 times, most recently
from
7eabbe3
to
912feb3
Compare
|
axum 0.6.0 has been released 🚀 |
|
Thanks! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes our axum integration work with axum 0.6.* which introduced some breaking changes.