Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should be able to use guards without string #1295

Open
AlbertMarashi opened this issue May 25, 2023 · 2 comments
Open

Should be able to use guards without string #1295

AlbertMarashi opened this issue May 25, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@AlbertMarashi
Copy link

AlbertMarashi commented May 25, 2023 •
edited

Description of the feature

Forcing users to wrap the guard in a string is annoying for ergonomics.

#[graphql(guard = "ScopeGuard::new(\"profile:read:email\")")]

Would like to be able to

#[graphql(guard = ScopeGuard::new("profile:read:email"))]
@AlbertMarashi AlbertMarashi added the enhancement New feature or request label May 25, 2023
@AlbertMarashi AlbertMarashi changed the title <Title> Should be able to use guards without string May 25, 2023
@AlbertMarashi AlbertMarashi mentioned this issue May 25, 2023
Closed
@AlbertMarashi
Copy link
Author

According to: TedDriggs/darling#239

Darling supports this feature as of 0.20

sunli829 added a commit that referenced this issue Jun 11, 2023
@sunli829
Attributes guard, process_with, complexity support expression o…
658842d 
…r string as value #1295
@AlbertMarashi
Copy link
Author

AlbertMarashi commented Oct 17, 2023 •
edited

@sunli829 was this fixed in above commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlbertMarashi