Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unintentional breaking change, removing #[async_trait], in patch release #1474

Open
eopb opened this issue Feb 20, 2024 · 2 comments
Open

Unintentional breaking change, removing #[async_trait], in patch release #1474

eopb opened this issue Feb 20, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@eopb
Copy link

eopb commented Feb 20, 2024

Version 7.0.2 introduced a breaking change, replacing #[async_trait] on public traits with async functions in traits #1468.

This has resulted in breakage for others, not just myself:

Ideally 7.0.2 should be yanked and #1468 reverted. #1468 should only be included in 8.0.0.

@eopb eopb added the bug Something isn't working label Feb 20, 2024
@noehoro
Copy link

noehoro commented Feb 22, 2024

We have faced the same issue.

@ckruse
Copy link

ckruse commented Feb 26, 2024

I face the issue that I now hit this error

overflow evaluating the requirement `&str: Sync`

when merging too many objects. I have to increase the recursion limit to 512 to get it working again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants