New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack overflow after upgrade to 7.0.2 #1506
Comments
I have a similar problem. I managed to get some queries to work with boxing a lot of the structs, but when the query gets more complex I still get the stack overflow (besides boxing the objects queried). So just boxing everything is not a solution... |
|
For people who have the same problem: I tried to solve this by trying to box things and had some success doing so. Simple queries and mutations work. But more complex queries still lead to a stack overflow, often not even in my code. In release builds ( For development and tests I just gave up and increased the stack size. Instead of using
Integration tests I run with This works for me. Edit: as far as I understand it, this happens because |
Related issue #1516 |
I am going to work on a feature flag to revert the removal of |
We are hitting the same issue. We also have a large merged object with pretty extensive input objects (with generics). If it helps:
Keep us up to date if you attempt to work on this and I'd be happy to help! |
I started to work on it, but the issue really is that the crate trait-variant which should be now the default instead of async-trait is just not up to the task which makes it hard to support both usecases |
Interesting. Thanks for the update here. Maybe an unintelligent question - would moving to something like Dynamic Schemas still produce the same issue? |
Yes since it uses the same traits |
I've been experiencing stack overflow in runtime, I didn't immediately notice this problem as I hadn't run tests for a long time during local development.
After hours of comparing changes, I found out that it happened after an upgrade to 7.0.2. After spending some more time trying to figure out what broke between 7.0.1 and 7.0.2 I found the cause.
The problem turned out to be the following PR #1468.
Expected Behavior
Working code as on 7.0.1
Actual Behavior
When calling GraphQL mutation and then executing a database transaction, application crashes
Using backtrace-on-stack-overflow I got the following stacktrace.
Stacktrace
//
I don't encounter stack overflow in
--release
, but that should not be the final solution.Steps to Reproduce the Problem
I'm not quite sure exactly how to reproduce this.
Specifications
7.0.2
WSL 2 Arch Linux
1.77
url
,chrono
,decimal
,dataloader
,playground
,opentelemetry
,apollo_tracing
,email-validator
,apollo_persisted_queries
,The text was updated successfully, but these errors were encountered: