-
-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLint Example in the book is not working #252
Comments
@callahanp I confirm this problem. Thank you. Here is what I found to fix it:
Apparently
Then try auto-fixing this block of code:
It will become:
Phew! |
@callahanp @klyburke Check this commit: 5a78d83 @klyburke Please upgrade packages in chapter folders and book text in Chapter 1. Thanks. |
Working as expected. Visual Studio Code at 1.41.1 test case: This issue and #251 may have been complicated by an intervening upgrade to Visual Studio Code. |
Re-opened till we make all edits. |
@tima101 edited Chapter 1 text for the changes in Workspace settings and |
ESLint couldn't find the config "airbnb" to extend from. I'm getting the following error: Oops! Something went wrong! :( ESLint: 6.1.0. ESLint couldn't find the config "airbnb" to extend from. Please check that the name of the config is correct. |
@victorray84 Hi. Have you followed these steps (part of the book): ? |
Yes, I've followed the steps. Still getting the same error. |
@victorray84 , thanks for reporting. I'll need more information to figure out the problem.
|
Hi, Thanks for ur reply. The comments are given below:
|
Hello @victorray84 Did you try to run I've cloned fresh new code from this repo. And gone to I have Yarn v1.21.1 installed and I tried
Then I tried to run I hope it helps. Thanks. |
Hi, |
@victorray84 Thank you again for bringing up this issue. I realized that Chapter 1 listed older packages for |
The text gives "This type of Eslint error is a result of Airbnb's format rule for arrow functions."
[1, 2, 3].map(function(x) {
const y = x + 1;
return x * y;
});
Pressing ctrl-s does not change the function to an arrow function as stated in the text.
linting seems to object only to the fact that the function has no name, not that a nameless function should be expressed as an arrow function.
The text was updated successfully, but these errors were encountered: